On 20.06.2025 20:28, Alejandro Vallejo wrote: > Moving forward the idea is for there to be: > 1. Basic DT support: used by dom0less/hyperlaunch. > 2. Full DT support: used for device discovery and HW setup. > > Rename HAS_DEVICE_TREE to HAS_DEVICE_TREE_DISCOVERY to describe (2), while > DOM0LESS_BOOT is left to describe (1).
Considering hyperlaunch this feels wrong to me. Did you consider splitting HAS_DEVICE_TREE into HAS_DEVICE_TREE_PARSE and HAS_DEVICE_TREE_DISCOVERY, as I suggested on the committers call? You weren't there, but Stefano said he was taking notes. > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -14,7 +14,7 @@ config CORE_PARKING > > config DOM0LESS_BOOT > bool "Dom0less boot support" if EXPERT > - depends on HAS_DOM0LESS && HAS_DEVICE_TREE && DOMAIN_BUILD_HELPERS > + depends on HAS_DOM0LESS && HAS_DEVICE_TREE_DISCOVERY && > DOMAIN_BUILD_HELPERS > default y > help > Dom0less boot support enables Xen to create and start domU guests > during > @@ -85,7 +85,7 @@ config HAS_ALTERNATIVE > config HAS_COMPAT > bool > > -config HAS_DEVICE_TREE > +config HAS_DEVICE_TREE_DISCOVERY > bool > select LIBFDT This select imo ought to move to HAS_DEVICE_TREE_PARSE, unless I misunderstand what LIBFDT covers. > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -6,9 +6,9 @@ obj-$(CONFIG_HYPFS_CONFIG) += config_data.o > obj-$(CONFIG_CORE_PARKING) += core_parking.o > obj-y += cpu.o > obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o > -obj-$(CONFIG_HAS_DEVICE_TREE) += device.o > +obj-$(CONFIG_HAS_DEVICE_TREE_DISCOVERY) += device.o > obj-$(filter-out $(CONFIG_X86),$(CONFIG_ACPI)) += device.o > -obj-$(CONFIG_HAS_DEVICE_TREE) += device-tree/ > +obj-$(CONFIG_HAS_DEVICE_TREE_DISCOVERY) += device-tree/ Here I'm less certain - is everything in that subdir truly "discovery" related? > --- a/xen/common/sched/Kconfig > +++ b/xen/common/sched/Kconfig > @@ -67,7 +67,7 @@ endmenu > > config BOOT_TIME_CPUPOOLS > bool "Create cpupools at boot time" > - depends on HAS_DEVICE_TREE > + depends on HAS_DEVICE_TREE_DISCOVERY > help > Creates cpupools during boot time and assigns cpus to them. Cpupools > options can be specified in the device tree. This similarly looks wrong to me. Whether to create CPU pools is purely a Xen-internal software thing, isn't it? Jan
