On 04.07.2025 09:07, Jiqian Chen wrote: > Refactor REGISTER_VPCI_INIT to contain more capability specific > information, this will benefit further follow-on changes to hide > capability when initialization fails. > > What's more, change the definition of init_header() since it is > not a capability and it is needed for all devices' PCI config space. > > After refactor, the "priority" of initializing capabilities isn't > needed anymore, so delete its related codes. > > Note: > Call vpci_make_msix_hole() in the end of init_msix() since the change > of sequence of init_header() and init_msix(). And delete the call of > vpci_make_msix_hole() in modify_decoding() since it is not needed. > > The cleanup hook is also added in this change, even if it's still > unused. Further changes will make use of it. > > Signed-off-by: Jiqian Chen <jiqian.c...@amd.com> > --- > There is a byte alignment problem in the array __start_vpci_array, which can > be solved after > "[PATCH] x86: don't have gcc over-align data" is merged.
I was meaning to suggest a way to actually detect the issue at build time, but sadly what's wanted to do so will first need adding to gas. Which now will likely be only after 2.45 went out. Jan