On 25.08.2025 13:04, Teddy Astie wrote:
> Le 24/08/2025 à 00:29, Petr Beneš a écrit :
>> +/* Type 7 -- Cache Information */
>> +static void *
>> +smbios_type_7_init(void *start)
>> +{
>> + /* Specification says Type 7 table has length of 13h for v2.1+. */
>> + BUILD_BUG_ON(sizeof(struct smbios_type_7) != 19);
>> +
>
> I would prefer having hex constants (so that it matches the number
> format the specification gives).
>
> e.g
> BUILD_BUG_ON(sizeof(struct smbios_type_7) != 0x13);
>
> (same for other checks)
While reviewing I was first inclined to ask the same, but then though that
with the hex values stated in comments it would be fine either way.
Jan
