On 03/09/2025 8:56 am, Jan Beulich wrote:
> Along the lines of what b89f8f054f96 ("x86/apic: Drop sync_Arb_IDs()")
> said, the function is dead logic as well: All 64-bit capable Intel systems
> have (at least) xAPIC (if not x2APIC).
>
> Even if Eclair can't know it, such code is violating Misra rule 2.2 (dead
> code; we didn't accept that yet, but - where possible - we probably would
> better follow it). Depending on one's reading, this code may actually be a
> violation of rule 2.1 (unreachable), which we did accept:
>
> "Code is unreachable if, ..., there is no combination of program inputs
> that can cause it to be executed."
>
> Otoh it's "only" __init code.
>
> As this removes the last user of APIC_XAPIC(), remove the macro as well.
>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
Same feedback as with the previous patch, albeit about the middle 3
paragraphs. Again with a strong preference for those to be removed,
Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
I'd not even spotted that APIC_XAPIC() existed. This being explicit
conformation of where XAPIC starts would have been helpful when doing
archaeology.
