On 19.12.2025 21:34, Oleksii Kurochko wrote: > On 12/18/25 3:32 PM, Jan Beulich wrote: >> On 17.12.2025 17:54, Oleksii Kurochko wrote: >>> --- a/xen/arch/riscv/include/asm/sbi.h >>> +++ b/xen/arch/riscv/include/asm/sbi.h >>> @@ -14,6 +14,10 @@ >>> >>> #include <xen/cpumask.h> >>> >>> +#define XEN_SBI_VER_MAJOR 0 >>> +#define XEN_SBI_VER_MINOR 2 >>> +#define XEN_SBI_IMPID 7 >> Are these numbers part of the spec (sorry, lack of a reference makes me >> wonder, >> plus if that were the case, I'd kind of expect the names to be SBI_XEN_..., >> not >> XEN_SBI_...)? > > XEN_SBI_IMPID is a number defined by the SBI specification: > > https://github.com/riscv-non-isa/riscv-sbi-doc/blob/master/src/ext-base.adoc#sbi-implementation-ids
I see. For this the name change below is then appropriate; for ... > XEN_SBI_VER_MAJOR and XEN_SBI_VER_MINOR somehow also is a part of the spec, > there is > no such defines explicitly, but it is real numbers of the SBI version. ... these two I'm unconvinced, otoh: If it is us to control the versions used here, the present names should imo remain. Brief comments may then also want adding to clarify the different origin of the numbers. Jan
