On 2026-01-14 08:43, Jan Beulich wrote:
... as far as we presently use them in the codebase.

Signed-off-by: Jan Beulich <[email protected]>

+            /* Leaf 0x6 - Therm/Perf. */
+            union {
+                uint32_t _6a;
+                struct {
+                    bool :1,

+                        hw_feedback:1;
+                };

+            union {
+                uint32_t _6c;
+                struct {
+                    bool hw_feedback_cap:1;

Maybe with an comment of "/* aperf/mperf */" since that is probably how it is better know? I was confused with hw_feedback above which is different.

Actually, looking at patch 2, I'd prefer leaving this named aperfmperf. While not the SDM name, I think it's a more common name for the feature.

Either way (but preferably with aperfmperf):

Reviewed-by: Jason Andryuk <[email protected]>

Regards,
Jason

Reply via email to