On 24/01/2026 12:32 am, Stefano Stabellini wrote:
> On Thu, 15 Jan 2026, [email protected] wrote:
>> From: Denis Mukhin <[email protected]>
>>
>> Use the new .config manipulation tool to toggle CONFIG_DEBUG in the
>> Xen automation build script.
>>
>> Signed-off-by: Denis Mukhin <[email protected]>
>> ---
>> automation/scripts/build | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/automation/scripts/build b/automation/scripts/build
>> index 7a81d229decd..ee1127c53dc5 100755
>> --- a/automation/scripts/build
>> +++ b/automation/scripts/build
>> @@ -27,7 +27,7 @@ else
>> # Start off with arch's defconfig
>> make -C xen defconfig
>>
>> - echo "CONFIG_DEBUG=${debug}" >> xen/.config
>> + xen/scripts/config --file xen/.config -${debug} DEBUG
> I'd suggest to add:
>
> debug="${debug:-n}"
>
> before calling xen/scripts/config to avoid errors in case debug is not
> set
>
> I could make the change on commit if you are OK with it
$debug is always set in automation, which is why the script is written
this way. But being resilient might be better.
>> if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then
>> echo "${EXTRA_XEN_CONFIG}" >> xen/.config
This part of context is the same pattern, and wants a similar
adjustment, although maybe the script wants a bulk adjustment mode.
This pattern is also repeated in the Eclair scripting too.
~Andrew
