On 26.01.2026 18:53, Andrew Cooper wrote:
> This makes the correctness of future changes more obvious.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <[email protected]>

Acked-by: Jan Beulich <[email protected]>

Especially with the way the diff is presented, could I talk you into ...

> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -455,10 +455,13 @@ void reset_cpuinfo(struct cpuinfo_x86 *c, bool 
> keep_basic)
>      CPU_DATA_INIT((*c));
>  }
>  
> -static void generic_identify(struct cpuinfo_x86 *c)
> +void identify_cpu(struct cpuinfo_x86 *c)
>  {
>       uint64_t val;
>       u32 eax, ebx, ecx, edx, tmp;
> +     int i;

... taking the opportunity and make this unsigned int?

Jan

Reply via email to