On 29.01.2026 03:46, Stefano Stabellini wrote:
> On Wed, 28 Jan 2026, Stefano Stabellini wrote:
>> On Wed, 28 Jan 2026, Jan Beulich wrote:
>>>> --- a/xen/drivers/char/console.c
>>>> +++ b/xen/drivers/char/console.c
>>>> @@ -612,10 +612,18 @@ static void __serial_rx(char c)
>>>> if ( !d )
>>>> return;
>>>>
>>>> - if ( is_hardware_domain(d) )
>>>
>>> This check is fully lost; shouldn't it be replaced by ...
>>>
>>>> +#ifdef CONFIG_SBSA_VUART_CONSOLE
>>>> + /* Prioritize vpl011 if enabled for this domain */
>>>> + if ( d->arch.vpl011.base_addr )
>>>> + {
>>>> + /* Deliver input to the emulated UART. */
>>>> + rc = vpl011_rx_char_xen(d, c);
>>>> + }
>>>> + else
>>>> +#endif
>>>
>>> ...
>>>
>>> if ( d->input_allowed )
>>>
>>> the latest here (not sure about the vpl011 intentions in this regard)?
>>
>> No because vuart has already input_allowed
>
> Sorry, let me rephrase this. You are right we need a d->input_allowed
> check. The check is already done as part of
>
> d = console_get_domain();
> if ( !d )
> return;
Can this be said explicitly in the description then?
Jan
