On 31/07/18 17:10, Marek Marczykowski-Górecki wrote:
> On Tue, Jul 31, 2018 at 10:00:24AM +0100, Wei Liu wrote:
>> On Tue, Jul 31, 2018 at 04:30:42AM +0200, Marek Marczykowski-Górecki wrote:
>>> --- a/tools/debugger/gdbsx/gx/gx_local.c
>>> +++ b/tools/debugger/gdbsx/gx/gx_local.c
>>> @@ -45,8 +45,8 @@ prnt_32regs(struct xg_gdb_regs32 *r32p)
>>> static void
>>> prnt_64regs(struct xg_gdb_regs64 *r64p)
>>> {
>>> - printf("rip:"XGF64" rsp:"XGF64" flags:"XGF64"\n", r64p->rip, r64p->rsp,
>>> - r64p->rflags);
>>> + printf("rip:"XGF64" rsp:"XGF64" flags:%08x\n", r64p->rip, r64p->rsp,
>>> + r64p->eflags);
>> I think it would be better to introduce XGF32 and XGFM32 in the header.
> I was inspired by prnt_32regs function, which use explicit %08x. Should
> it be changed there too (to PRIx32)? Otherwise that would be
> inconsistent (and maybe warrant a totally separate cleanup).
Tbh, I'd stick with %08x because that's what we'd expect in the
hypervisor. If you'd like clean things up then please do, but it would
be rude to block this bugfix on cleanup.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
