> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 08 August 2018 11:11 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: xen-devel <xen-devel@lists.xenproject.org> > Subject: Re: [PATCH v3] x86/hvm: remove default ioreq server > > >>> On 07.08.18 at 17:42, <paul.durr...@citrix.com> wrote: > > My recent patch [1] to qemu-xen-traditional removes the last use of the > > 'default' ioreq server in Xen. (This is a catch-all ioreq server that is > > used if no explicitly registered I/O range is targetted). > > > > This patch can be applied once that patch is committed, to remove the > > (>100 lines of) redundant code in Xen. > > > > NOTE: The removal of the special case for HVM_PARAM_DM_DOMAIN in > > hvm_allow_set_param() is not directly related to removal of > > default ioreq servers. It could have been cleaned up at any time > > after commit 9a422c03 "x86/hvm: stop passing explicit domid to > > hvm_create_ioreq_server()". It is now added to the new > > deprecated sets introduced by this patch. > > > > [1] https://lists.xenproject.org/archives/html/xen-devel/2018- > 08/msg00270.html > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > Acked-by: Andrew Cooper <andrew.coop...@citrix.com> > > Reviewed-by: Jan Beulich <jbeul...@suse.com>
Thanks. > with one more cosmetic adjustment: > > > --- a/xen/include/public/hvm/params.h > > +++ b/xen/include/public/hvm/params.h > > @@ -81,9 +81,13 @@ > > #define HVM_PARAM_PAE_ENABLED 4 > > > > #define HVM_PARAM_IOREQ_PFN 5 > > - > > #define HVM_PARAM_BUFIOREQ_PFN 6 > > + > > +#ifdef __XEN__ > > +/* These parameters is deprecated and its meaning is undefined */ > > +#define HVM_PARAM_DM_DOMAIN 13 > > #define HVM_PARAM_BUFIOREQ_EVTCHN 26 > > +#endif > > The comment was only partly switched to plural. > Oh, so it was. I guess this can be fixed on commit unless you'd prefer I send a v4. Paul > Jan > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
