On 02/08/18 07:02, Jan Beulich wrote: >>>> On 01.08.18 at 18:08, <andrew.coop...@citrix.com> wrote: >> On 01/08/18 16:36, Jan Beulich wrote: >>> Clearly we want to put a vCPU to sleep if it is _not_ already down. >>> >>> Signed-off-by: Jan Beulich <jbeul...@suse.com> >>> --- >>> TBD: Since the flaw apparently never mattered, I imply that the function >>> is never called with any vCPU up. Hence an alternative might be to >>> simply return an error if a vCPU doesn't have VPF_down set. >> With Remus/COLO, we should hit this path with an up vCPU on every >> iteration after the first. Given this bug, I'm struggling to see how it >> works at all. > Well, that would rule out the alternative suggestion, but since > this is neither an ack nor a nak - what do you suggest we do?
Apologies for completely missing this. The fix is obvious, so Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> I don't think we can instead return an error, because of the Remus/COLO usecase, but I expect someone is going to have some debugging to do... ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
