On 31/08/18 00:14, Boris Ostrovsky wrote: > On 08/30/2018 07:11 PM, Boris Ostrovsky wrote: >> On 08/28/2018 01:39 PM, Andrew Cooper wrote: >>> By making {vmx,svm} in hvm_vcpu into an anonymous union (consistent with >>> domain side of things), the hvm_{vmx,svm} defines can be dropped, and all >>> code >>> refer to the correctly-named fields. This means that the data hierachy is >>> no >>> longer obscured from grep/cscope/tags/etc. >>> >>> Reformat one comment and switch one bool_t to bool while making changes. >>> >>> No functional change. >>> >>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >>> >> Do we still support pre-4.6 gcc? > Or 4.4.6? I don't remember.
I'm aware of that bug and it is 4.6 iirc. However, in this case there are no initialisers. The memory starts off as a zeroed heap page and has a plethora of init() functions call on it to set things up. > > -boris > > >> They have a bug that doesn't allow >> initializers for anonymous structs/unions. I don't know whether we have >> any for vmx/svm, but I thought I'd mention this just in case. >> >> Other than that, for SVM bits in patches 3,4,6 and 7 >> >> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Thanks. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel