On 08/09/18 16:18, zhong jiang wrote: > kfree has taken null pointer into account. So just remove the > condition check before kfree. > > Signed-off-by: zhong jiang <zhongji...@huawei.com> > --- > drivers/xen/xen-acpi-processor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/xen-acpi-processor.c > b/drivers/xen/xen-acpi-processor.c > index fbb9137..7e1d49e 100644 > --- a/drivers/xen/xen-acpi-processor.c > +++ b/drivers/xen/xen-acpi-processor.c > @@ -268,7 +268,7 @@ static int push_pxx_to_hypervisor(struct acpi_processor > *_pr) > pr_warn("(_PXX): Hypervisor error (%d) for ACPI CPU%u\n", > ret, _pr->acpi_id); > err_free: > - if (!IS_ERR_OR_NULL(dst_states)) > + if (!IS_ERR(dst_states))
This is just a change of the condition, not a removal. I don't think change is worth it. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel