Re: [Xen-devel] [PATCH] traps: coding style fixes

[Julien Grall]

On 11/09/18 08:18, Andrii Anisov wrote:

From: Andrii Anisov <andrii_ani...@epam.com>

Signed-off-by: Andrii Anisov <andrii_ani...@epam.com>
---
  xen/arch/arm/traps.c | 12 ++++++++----
  1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 9ae64ae..45fb3d5 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -244,7 +244,8 @@ static register_t *select_user_reg(struct cpu_user_regs 
*regs, int reg)
       */
  #define REGOFFS(R) offsetof(struct cpu_user_regs, R)

- switch ( reg ) {

+    switch ( reg )
+    {
      case 0 ... 7: /* Unbanked registers */
          BUILD_BUG_ON(REGOFFS(r0) + 7*sizeof(register_t) != REGOFFS(r7));
          return &regs->r0 + reg;
@@ -1429,7 +1430,8 @@ static void do_debug_trap(struct cpu_user_regs *regs, 
unsigned int code)
  {
      uint32_t reg;
      uint32_t domid = current->domain->domain_id;

While you are at fixing coding style: newline here.

-    switch ( code ) {
+    switch ( code )
+    {
      case 0xe0 ... 0xef:
          reg = code - 0xe0;
          printk("DOM%d: R%d = 0x%"PRIregister" at 0x%"PRIvaddr"\n",
@@ -2071,7 +2073,8 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)

enter_hypervisor_head(regs); - switch (hsr.ec) {

+    switch (hsr.ec)

Xen coding style requires space after ( and before ).

+    {
      case HSR_EC_WFI_WFE:
          /*
           * HCR_EL2.TWI, HCR_EL2.TWE
@@ -2270,7 +2273,8 @@ void leave_hypervisor_tail(void)
      while (1)
      {
          local_irq_disable();
-        if (!softirq_pending(smp_processor_id())) {
+        if (!softirq_pending(smp_processor_id()))

Same here.

+        {
              vgic_sync_to_lrs();

/*

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel