>>> On 11.09.18 at 16:06, <paul.durr...@citrix.com> wrote: >> -----Original Message----- >> From: Paul Durrant >> Sent: 11 September 2018 15:04 >> To: 'Jan Beulich' <jbeul...@suse.com> >> Cc: Julien Grall <julien.gr...@arm.com>; Andrew Cooper >> <andrew.coop...@citrix.com>; Wei Liu <wei.l...@citrix.com>; George >> Dunlap <george.dun...@citrix.com>; Ian Jackson <ian.jack...@citrix.com>; >> Stefano Stabellini <sstabell...@kernel.org>; xen-devel <xen- >> de...@lists.xenproject.org>; Konrad Rzeszutek Wilk >> <konrad.w...@oracle.com>; Tim (Xen.org) <t...@xen.org> >> Subject: RE: [PATCH v2] tools: add option to explicitly enable VirtFS in > QEMU >> build >> >> > -----Original Message----- >> > From: Jan Beulich [mailto:jbeul...@suse.com] >> > Sent: 11 September 2018 14:45 >> > To: Paul Durrant <paul.durr...@citrix.com> >> > Cc: Julien Grall <julien.gr...@arm.com>; Andrew Cooper >> > <andrew.coop...@citrix.com>; Wei Liu <wei.l...@citrix.com>; George >> > Dunlap <george.dun...@citrix.com>; Ian Jackson >> <ian.jack...@citrix.com>; >> > Stefano Stabellini <sstabell...@kernel.org>; xen-devel <xen- >> > de...@lists.xenproject.org>; Konrad Rzeszutek Wilk >> > <konrad.w...@oracle.com>; Tim (Xen.org) <t...@xen.org> >> > Subject: Re: [PATCH v2] tools: add option to explicitly enable VirtFS in >> QEMU >> > build >> > >> > >>> On 11.09.18 at 15:37, <paul.durr...@citrix.com> wrote: >> > > 9pfs support has been a documented feature since Xen 4.9, but QEMU >> will >> > > not be built with backend support unless VirtFS is enabled, which is >> > > predicated on the libcap and libattr dev packages being installed. This >> > > is >> > > not obvious to anyone intending to use 9pfs. >> > > >> > > This patch adds an 'enable-9pfs' option to configure which, if specified, >> > > will cause '--enable-virtfs' to be passed to QEMU's configure. This will >> > > cause the dependency on libcap and libattr to be called out if the >> packages >> > > are not in installed. >> > > >> > > For completeness, specifying 'disable-9pfs' will cause >> > > '--disable-virtfs' to >> > > be passed to QEMU's confgure and not specifying an option will keep the >> > > previous behaviour of predicating VirtFS on whether the libcap and >> > > libattr >> > > packages are installed. >> > > >> > > NOTE: The shell script in configure might look odd, but it is coded for >> > > consistency with other similar logic blocks within the file. >> > > >> > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> >> > > --- >> > > Cc: Andrew Cooper <andrew.coop...@citrix.com> >> > > Cc: George Dunlap <george.dun...@eu.citrix.com> >> > > Cc: Ian Jackson <ian.jack...@eu.citrix.com> >> > > Cc: Jan Beulich <jbeul...@suse.com> >> > > Cc: Julien Grall <julien.gr...@arm.com> >> > > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> >> > > Cc: Stefano Stabellini <sstabell...@kernel.org> >> > > Cc: Tim Deegan <t...@xen.org> >> > > Cc: Wei Liu <wei.l...@citrix.com> >> > > >> > > v2: >> > > - Add the configure option rather then enabling VirtFS in all Linux > builds. >> > > --- >> > > config/Tools.mk.in | 1 + >> > > tools/Makefile | 10 +++++++++- >> > > tools/configure | 29 +++++++++++++++++++++++++++++ >> > > 3 files changed, 39 insertions(+), 1 deletion(-) >> > >> > Wouldn't you first and foremost need to edit tools/configure.ac? >> > >> >> No idea. There seem to be several layer of magic so it's quite believable >> that >> I've missed one. Any clue as to what I need to do there? > > OIC... configure is generated despite being checked in... Well that's nice > and obvious!
That's pretty common for projects using autoconf to generate their ./configure scripts. Eliminates the requirement for everyone to have a suitable autoconf version installed. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
