On 04/10/2018 13:22, George Dunlap wrote: > On 10/04/2018 11:51 AM, Juergen Gross wrote: >> Modify the xentrace utility to allow sparse cpu list resulting in not >> all possible cpus having a trace buffer allocated. >> >> Signed-off-by: Juergen Gross <jgr...@suse.com> > > This looks good: > > Reviewed-by: George Dunlap <george.dun...@citrix.com> > > Would you mind if I fold in the attached comment when committing?
With some adaptions, please: - /* Map per-cpu buffers */ + /* + * Map per-cpu buffers. NB that if a cpus is offline, it may have s/ cpus / cpu / + * no trace buffers. In this case, the the respective mfn_offset s/the the/the/ + * will be 0, and the index should be ignored. + */ Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
