On 01/11/2018 02:22, Tian, Kevin wrote: >> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] >> Sent: Tuesday, October 30, 2018 8:41 PM >> >> On 30/10/2018 07:41, Tian, Kevin wrote: >>>> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] >>>> Sent: Friday, October 12, 2018 11:28 PM >>>> >>>> As a convenient helper function and refactor the code to use it. >>>> >>>> No functional change. >>>> >>>> Signed-off-by: Sergey Dyasli <sergey.dya...@citrix.com> >>> >>> since vmcx is hvm abstracted term, what about using this >>> helper in svm side too? >> >> I couldn't find any code in nestedsvm.c that would benefit from this new >> helper. >> > > just a quick check: > > if (nv->nv_vvmcx != NULL && nv->nv_vvmcxaddr != vmcbaddr) { > ASSERT(nv->nv_vvmcxaddr != INVALID_PADDR); > hvm_unmap_guest_frame(nv->nv_vvmcx, 1); > nv->nv_vvmcx = NULL; > nv->nv_vvmcxaddr = INVALID_PADDR; > }
Yes, that's the only usage and it looks better open coded IMHO. But I can use the new helper here also, if you insist. Thanks, Sergey _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
