>>> On 31.10.18 at 13:43, <paul.durr...@citrix.com> wrote: > --- /dev/null > +++ b/xen/arch/x86/hvm/viridian/time.c > @@ -0,0 +1,245 @@ > +/************************************************************************** > * > + * time.c > + * > + * An implementation of some time related Viridian enlightenments. > + * See Microsoft's Hypervisor Top Level Functional Specification. > + * for more information. > + */ > + > +#include <xen/domain_page.h> > +#include <xen/hypercall.h> > +#include <xen/sched.h> > +#include <xen/version.h> > + > +#include <asm/apic.h> > +#include <asm/hvm/support.h> > + > +typedef struct _HV_REFERENCE_TSC_PAGE > +{ > + uint32_t TscSequence; > + uint32_t Reserved1; > + uint64_t TscScale; > + int64_t TscOffset; > + uint64_t Reserved2[509]; > +} HV_REFERENCE_TSC_PAGE, *PHV_REFERENCE_TSC_PAGE;
And you want to continue to have it all upper case, despite us normally using such identifiers for #define-s only? Apart from that same remark regarding the placement of the function declarations as for the previous patch. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel