On 23/11/2018 13:25, Juergen Gross wrote: > In debug builds the hypervisor will deliberately clobber processed > elements of the multicall structure. In order to ease diagnostic data > printout in the affected guest only clobber elements which didn't > return an error. > > Signed-off-by: Juergen Gross <[email protected]> > --- > xen/common/multicall.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/common/multicall.c b/xen/common/multicall.c > index 5a199ebf8f..48622619ce 100644 > --- a/xen/common/multicall.c > +++ b/xen/common/multicall.c > @@ -74,6 +74,7 @@ do_multicall( > ASSERT_NOT_IN_ATOMIC(); > > #ifndef NDEBUG > + if ( (long)mcs->call.result >= 0 )
While I appreciate your point and agree that this is good in principle, the failure condition is per-hypercall, and not always negative. I've tried playing a similar game before and couldn't come up with a viable option. ~Andrew _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
