> -----Original Message----- > From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: 18 January 2019 16:07 > To: Paul Durrant <paul.durr...@citrix.com>; xen-devel@lists.xenproject.org > Cc: Chao Gao <chao....@intel.com>; Sander Eikelenboom > <li...@eikelenboom.it>; Jan Beulich <jbeul...@suse.com>; Andrew Cooper > <andrew.coop...@citrix.com>; Wei Liu <wei.l...@citrix.com>; Roger Pau > Monne <roger....@citrix.com>; George Dunlap <george.dun...@citrix.com>; > Ian Jackson <ian.jack...@citrix.com>; Konrad Rzeszutek Wilk > <konrad.w...@oracle.com>; Stefano Stabellini <sstabell...@kernel.org>; Tim > (Xen.org) <t...@xen.org>; Jun Nakajima <jun.nakaj...@intel.com>; Kevin Tian > <kevin.t...@intel.com> > Subject: Re: [PATCH] iommu: specify page_count rather than page_order to > iommu_map/unmap()... > > > > On 18/01/2019 16:03, Paul Durrant wrote: > > ...and remove alignment assertions. > > > > Testing shows that certain callers of iommu_legacy_map/unmap() specify > > order > 0 ranges that are not order aligned thus causing one of the > > IS_ALIGNED() assertions to fire. > > > > This patch removes those assertions and modifies iommu_map/unmap() and > > iommu_legacy_map/unmap() to take a page_count argument rather than a > > page_order. Using a count actually makes more sense because the valid > > set of mapping orders is specific to the IOMMU implementation and to it > > should be up to the implementation specific code to translate a mapping > > count into an optimal set of mapping orders (when the code is finally > > modified to support orders > 0). > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > --- > > Reported-by: Chao Gao <chao....@intel.com> > > Reported-by: Sander Eikelenboom <li...@eikelenboom.it> > You put those tags after ---. Don't you want them in the final commit? >
Good point. If there is a v2 then I'll move them, otherwise I hope that can be fixed up on commit. Paul > Cheers, > > -- > Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
