On 24/01/2019 18:47, Nuernberger, Stefan wrote: > On Thu, 2019-01-24 at 20:33 +0200, Andrii Anisov wrote: >> From: Andrii Anisov <andrii_ani...@epam.com> >> >> Signed-off-by: Andrii Anisov <andrii_ani...@epam.com> >> --- >> xen/arch/arm/gic-vgic.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c >> index 48922f5..684f2d1 100644 >> --- a/xen/arch/arm/gic-vgic.c >> +++ b/xen/arch/arm/gic-vgic.c >> @@ -443,7 +443,7 @@ int vgic_connect_hw_irq(struct domain *d, struct >> vcpu *v, unsigned int virq, >> int ret = 0; >> >> /* "desc" is optional when we disconnect an IRQ. */ >> - ASSERT(connect && desc); >> + ASSERT(connect || desc); > > I assume it should be ASSERT(!connect || desc);
Drawing the truth table and throwing all my CS text book boolean knowledge at it :-) Yes, Stefan's version matches the comment. Plus what Julien said about the commit message. Cheers, Andre >> >> /* We are taking to rank lock to prevent parallel connections. >> */ >> vgic_lock_rank(v_target, rank, flags); _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
