> -----Original Message-----
> From: Paul Durrant
> Sent: 11 March 2019 17:46
> To: 'Jan Beulich' <[email protected]>
> Cc: Andrew Cooper <[email protected]>; Roger Pau Monne
> <[email protected]>; Wei Liu
> <[email protected]>; xen-devel <[email protected]>
> Subject: RE: [PATCH 5/6] x86: remove defunct init/load/save_msr() hvm_funcs
>
> > -----Original Message-----
> > From: Jan Beulich [mailto:[email protected]]
> > Sent: 08 March 2019 16:50
> > To: Paul Durrant <[email protected]>
> > Cc: Andrew Cooper <[email protected]>; Roger Pau Monne
> > <[email protected]>; Wei Liu
> > <[email protected]>; xen-devel <[email protected]>
> > Subject: Re: [PATCH 5/6] x86: remove defunct init/load/save_msr() hvm_funcs
> >
> > >>> On 07.01.19 at 13:02, <[email protected]> wrote:
> > > @@ -1472,10 +1468,7 @@ static int hvm_load_cpu_msrs(struct domain *d,
> > > hvm_domain_context_t *h)
> > > return -EOPNOTSUPP;
> > > /* Checking finished */
> > >
> > > - if ( hvm_funcs.load_msr )
> > > - err = hvm_funcs.load_msr(v, ctxt);
> > > -
> > > - for ( i = 0; !err && i < ctxt->count; ++i )
> > > + for ( i = 0; i < ctxt->count; ++i )
> > > {
> > > switch ( ctxt->msr[i].index )
> > > {
> >
> > err can become set to non-zero in the loop body further down from here,
> > so I don't think you should alter the loop header.
>
> True. Bailing early is a change of semantic, so I'll drop the check.
^ Not
>
> Paul
>
> >
> > Jan
> >
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
