On Tue, Mar 26, 2019 at 01:16:35PM +0000, Wei Liu wrote: > On Mon, Mar 25, 2019 at 10:20:05PM +0000, YOUNG, MICHAEL A. wrote: > > if ty.init_fn is not None: > > --- xen-4.12.0-rc6/tools/pygrub/src/GrubConf.py.orig 2019-03-24 > > 22:44:05.502581989 +0000 > > +++ xen-4.12.0-rc6/tools/pygrub/src/GrubConf.py 2019-03-24 > > 22:49:14.025934786 +0000 > > @@ -230,10 +230,10 @@ > > def _get_default(self): > > return self._default > > def _set_default(self, val): > > - if val == "saved": > > + if val == "saved" or not val.isdecimal():
Your change suggested there could be a non-decimal string that is not "saved" -- is this really needed? Wei. > > self._default = 0 > > else: > > - self._default = val > > + self._default = int(val) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel