On 28/03/2019 14:54, Jan Beulich wrote:
> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -26,6 +26,19 @@
> const struct iommu_init_ops *__initdata iommu_init_ops;
> struct iommu_ops __read_mostly iommu_ops;
>
> +int __init iommu_hardware_setup(void)
> +{
> + if ( !iommu_init_ops )
> + return -ENODEV;
> +
> + if ( !iommu_ops.init )
> + iommu_ops = *iommu_init_ops->ops;
> + else
> + ASSERT(iommu_ops.init == iommu_init_ops->ops->init);
What is this ASSERT() intended to catch? We pass through this function
exactly once, making the else path dead.
Do you have some plans in future series which make this a non-init function?
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
