On 12/04/2019 17:39, Tamas K Lengyel wrote: > The p2m_altp2m_lazy_copy is responsible for lazily populating an altp2m view > when the guest traps out due to no EPT entry being present in the active view. > Currently the function took several inputs that it didn't use and also > locked/unlocked gfns when it didn't need to.
I've got a series, "[PATCH 00/14] XSA-277 followup" which is still waiting for mm review, which cleans some of this up, but came to a different conclusion about the locking safety of the GFNs. Specifically, [PATCH 04/14] x86/p2m: Fix locking in p2m_altp2m_lazy_copy() (and some other cleanup changes in patch 5 and 6) which extends the duration of the gfn locks. I admit that I hadn't spotted that gpa/gla/npfec was unnecessary, and that does look like an improvement. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
