On 3/7/19 10:34 AM, Jan Beulich wrote: > While I've not observed this myself, gcc 9 (imo validly) reportedly may > complain > > trace.c: In function '__trace_hypercall': > trace.c:826:19: error: taking address of packed member of 'struct > <anonymous>' may result in an unaligned pointer value > [-Werror=address-of-packed-member] > 826 | uint32_t *a = d.args; > > and the fix is rather simple - remove the __packed attribute. Introduce > a BUILD_BUG_ON() as replacement, for the unlikely case that Xen might > get ported to an architecture where array alignment higher that that of > its elements. > > Reported-by: Martin Liška <[email protected]> > Signed-off-by: Jan Beulich <[email protected]>
OK, you convinced me. Acked-by: George Dunlap <[email protected]> At some point we'll probably need a prettier way to do this. -George _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
