Hi Jan,
On 6/4/19 8:15 AM, Jan Beulich wrote:
On 03.06.19 at 18:11, <julien.gr...@arm.com> wrote:
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -197,6 +197,7 @@
} while ( 0 )
#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val)
+#if defined(__XEN__) || defined(__XEN_TOOLS__)
#if defined(__GNUC__) && !defined(__STRICT_ANSI__)
/* Anonymous union includes both 32- and 64-bit names (e.g., r0/x0). */
# define __DECL_REG(n64, n32) union { \
@@ -272,6 +273,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_core_regs_t);
#undef __DECL_REG
+#endif
+
typedef uint64_t xen_pfn_t;
#define PRI_xen_pfn PRIx64
#define PRIu_xen_pfn PRIu64
I'm puzzled by you still adding another #if, rather than moving the
block down into the existing one. You said you'd wait for Stefano's
opinion, and he asked that you follow my suggestion. Did I miss
some further part of the discussion?
No I have sent the wrong version. Not sure how because the changes are
correct in the branch I am using.
Sorry for the inconvenience, I will resend the patch.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel