>>> On 11.06.19 at 19:01, <paul.durr...@citrix.com> wrote: > @@ -77,6 +76,7 @@ static void update_reference_tsc(struct domain *d, bool > initialize) > * ticks per 100ns shifted left by 64. > */ > p->TscScale = ((10000ul << 32) / d->arch.tsc_khz) << 32; > + p->TscOffset = trc->off; > smp_wmb();
Even having written the description it's not immediately obvious to me why this is an okay change to make, not the least when thinking about a guest migrating in from an older version. At the very least don't you think the comment above may want slightly extending? Everything else looks plausible to me. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel