>>> On 19.06.19 at 16:30, <roger....@citrix.com> wrote: > On Wed, Jun 19, 2019 at 12:20:40PM +0100, Andrew Cooper wrote: >> Since the MB1/MB2 builds aren't relocatable, I think we might be able to >> get away with simply excluding them in the non-EFI build. > > Hm, OK. I'm slightly loss then. I've taken a look at the history of > xen/arch/x86/efi/relocs-dummy.S and it's not clear to me why such a > dummy file was added. My guess is that it's done in order to prevent > missing symbols errors. If that's the case I guess the code that makes > use of such symbols can be guarded, and the dummy file removed?
Missing symbols errors - yes. But how would you remove the dummy one, which is a place holder in stage 1 linking for what will be real data in stages 2 and 3? I don't think we should ignore unresolved symbols in stage 1. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
