>>> On 25.06.19 at 13:08, <roger....@citrix.com> wrote: > Sorry for not being clear. By remove I mean `git rm > xen/arch/x86/efi/relocs-dummy.S` and fix the build, like the diff > appended below. > > Is there any reason we should keep the dummy .reloc in the ELF > output?
Yes, there is. And yes, I was afraid you'd mean this. > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -39,6 +39,7 @@ extern const intpte_t __page_tables_start[], > __page_tables_end[]; > #define PE_BASE_RELOC_HIGHLOW 3 > #define PE_BASE_RELOC_DIR64 10 > > +#ifdef XEN_BUILD_PE This is an identifier available to Makefiles only. You also can't propagate it to .c files, as these get compiled just once to produce _both_ PE and ELF binary. So while what you suggest may build, it'll result in a broken xen.efi. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
