On Tue, 2019-07-16 at 14:59 -0600, Tamas K Lengyel wrote: > > diff --git a/xen/include/public/vm_event.h > > b/xen/include/public/vm_event.h > > index 959083d..c48bc21 100644 > > --- a/xen/include/public/vm_event.h > > +++ b/xen/include/public/vm_event.h > > @@ -36,6 +36,37 @@ > > #include "io/ring.h" > > > > /* > > + * There are currently three types of VM events. > > + */ > > This is a bit misleading and confusing if someone just looks at the > header. Right now we actually have 14 different VM_EVENT_REASONs > defined. What we have 3 of are the different rings where these events > would be delivered, with paging and sharing having their own ring > separate from the events under the "monitor" label. > The reason I replaced "ring" with "type" is because the next patches introduce a new mechanism for handling requests/responses without using a ring.
I assumed the following naming convention: Type - the "subsystem" which generates the vm_event request: monitor, paging or sharing. Reason - The reason why the vm_event request was sent (e.g. VM_EVENT_REASON_MEM_ACCESS) However, I do understand that it can be misleading without a proper description so I will update the description. Many thanks, Petre _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
