On 16.07.2019 19:28, Andrew Cooper wrote:
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -1407,7 +1407,8 @@ static int alloc_l1_table(struct page_info *page)
> return 0;
>
> fail:
> - gdprintk(XENLOG_WARNING, "Failure in alloc_l1_table: slot %#x\n", i);
> + gdprintk(XENLOG_WARNING,
> + "Failure in alloc_l1_table: slot %#x, ret %d\n", i, ret);
To make it slightly less output without losing information, in cases
like this I generally prefer "Failure %d in alloc_l1_table: slot %#x\n".
Seeing ...
> @@ -1505,7 +1506,8 @@ static int alloc_l2_table(struct page_info *page,
> unsigned long type)
> }
> else if ( rc < 0 && rc != -EINTR )
> {
> - gdprintk(XENLOG_WARNING, "Failure in alloc_l2_table: slot
> %#x\n", i);
> + gdprintk(XENLOG_WARNING,
> + "Failure in alloc_l2_table: slot %#x, rc %d\n", i, rc);
... this for comparison it is, imo, not relevant to actually have names
of local variables in logged messages.
Preferably with this adjusted
Acked-by: Jan Beulich <jbeul...@suse.com>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
