On 7/17/19 10:55 PM, Denis Obrezkov wrote:
Hi,
Hi,
Well, Xen has been supported the omap5 for quite a while. So there are
two possibilities regarding the current SMP code:
1) It is totally broken and therefore never worked on any omap5
platform.
2) It works but with maybe modification in U-boot.
Looking at the mailing list archive and wiki, I believe 2) is closer to
the current reality. So this raise the question whether your patch will
break any existing setup.
Don't get me wrong, the code is perfectly fine as, to the best of my
knowledge, it matches what Linux does. However, I would like to see an
analysis written in the commit message regarding what's going to happen
for any existing setup.
Cheers,
I hoped to hear more opinions because I don't really understand where to
start - I don't know much about how xen and Linux worked with omap5.
I am afraid I never had the chance to use the omap5. I provided an
analysis in my first answer based on my finding. This is the kind of
things I would expect in the commit message.
However, I would like more opinions from people who have been working
with the omap5 platform. I would give until Monday for an answer, if
none is received then please go ahead resending a version with my analysis.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel