On 18.07.19 19:57, Dario Faggioli wrote:
On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote:
Allocate a struct sched_unit for each vcpu. This removes the need to
have it locally on the stack in schedule.c.
Signed-off-by: Juergen Gross <jgr...@suse.com>
And this patch looks ok as well.
However, I don't see much value in not doing what's done here in patch
4 already (it's pretty much only line changed by patch 4 that are being
changed again here).
Is there a particular reason you think it's important to keep these two
patches separated?
Not important, but I thought it would make it more clear.
If you like it better I can merge the two patches.
Ah, my comment about 'unit' --> 'su' --in case you think it's feasible-
- applies to struct members as well, of course, e.g., here:
@@ -160,6 +161,7 @@ struct vcpu
struct timer poll_timer; /* timeout for SCHEDOP_poll */
+ struct sched_unit *sched_unit;
void *sched_priv; /* scheduler-specific data */
struct vcpu_runstate_info runstate;
I have to disagree here: this is no scheduler private structure, so I
believe the struct member names should be descriptive. I guess this is
the reason why there are many more struct members named "vcpu" than "v".
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel