On 16/07/2019 17:37, Jan Beulich wrote: > The functions will want to know IOMMU properties (specifically the IRTE > size) subsequently. > > Rather than introducing a second error path bogusly returning -E... from > amd_iommu_read_ioapic_from_ire(), also change the existing one to follow > VT-d in returning the raw (untranslated) IO-APIC RTE.
I'm not convinced that this is any less bogus. The caller still can't figure out if an error occurred. Still, consistency with VT-d is less bad overall. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Acked-by: Andrew Cooper <andrew.coop...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel