On 19.07.2019 16:07, Roger Pau Monne wrote:
> This reduces the number of parameters of the function to two, and
> simplifies some of the calling sites.
>
> While there convert {IGD/IOH}_DEV to be a pci_sbdf_t itself instead of
> a device number.
>
> Signed-off-by: Roger Pau Monné <roger....@citrix.com>
> Acked-by: Brian Woods <brian.wo...@amd.com>
> Reviewed-by: Kevin Tian <kevin.t...@intel.com>
Acked-by: Jan Beulich <jbeul...@suse.com>
with one further remark (easily addressed while committing):
> @@ -128,9 +128,9 @@ static void __init map_igd_reg(void)
> if ( igd_reg_va )
> return;
>
> - igd_mmio = pci_conf_read32(0, 0, IGD_DEV, 0, PCI_BASE_ADDRESS_1);
> + igd_mmio = pci_conf_read32(IGD_DEV, PCI_BASE_ADDRESS_1);
> igd_mmio <<= 32;
> - igd_mmio += pci_conf_read32(0, 0, IGD_DEV, 0, PCI_BASE_ADDRESS_0);
> + igd_mmio += pci_conf_read32(IGD_DEV, PCI_BASE_ADDRESS_0);
There looks to be a stray blank in here.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
