> -----Original Message----- > From: Roger Pau Monne <[email protected]> > Sent: 25 July 2019 10:48 > To: Paul Durrant <[email protected]> > Cc: [email protected]; Stefano Stabellini > <[email protected]>; Wei Liu <[email protected]>; > Konrad Rzeszutek Wilk <[email protected]>; George Dunlap > <[email protected]>; Andrew > Cooper <[email protected]>; Ian Jackson <[email protected]>; Tim > (Xen.org) <[email protected]>; > Julien Grall <[email protected]>; Jan Beulich <[email protected]>; Daniel > De Graaf > <[email protected]> > Subject: Re: [Xen-devel] [PATCH 5/6] domain: remove the 'is_xenstore' flag > > On Tue, Jul 23, 2019 at 05:06:08PM +0100, Paul Durrant wrote: > > This patch introduces a convenience macro, is_xenstore_domain(), which > > tests the domain 'createflags' directly and then uses that in place of > > the 'is_xenstore' flag. > > > > Signed-off-by: Paul Durrant <[email protected]> > > Reviewed-by: Roger Pau Monné <[email protected]> >
Thanks. > Just one request below (which is not related to your code actually). > > > --- > > Cc: Andrew Cooper <[email protected]> > > Cc: George Dunlap <[email protected]> > > Cc: Ian Jackson <[email protected]> > > Cc: Jan Beulich <[email protected]> > > Cc: Julien Grall <[email protected]> > > Cc: Konrad Rzeszutek Wilk <[email protected]> > > Cc: Stefano Stabellini <[email protected]> > > Cc: Tim Deegan <[email protected]> > > Cc: Wei Liu <[email protected]> > > Cc: Daniel De Graaf <[email protected]> > > --- > > xen/common/domain.c | 5 +---- > > xen/common/domctl.c | 2 +- > > xen/include/xen/sched.h | 7 +++++-- > > xen/include/xsm/dummy.h | 2 +- > > 4 files changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/xen/common/domain.c b/xen/common/domain.c > > index 6f405d2541..5703da357f 100644 > > --- a/xen/common/domain.c > > +++ b/xen/common/domain.c > > @@ -429,11 +429,8 @@ struct domain *domain_create(domid_t domid, > > watchdog_domain_init(d); > > init_status |= INIT_watchdog; > > > > - if ( d->createflags & XEN_DOMCTL_CDF_xs_domain ) > > - { > > - d->is_xenstore = 1; > > + if ( is_xenstore_domain(d) ) > > d->disable_migrate = 1; > > While here can you also fix this line to use true instead of 1? > Sure. Paul > Thanks, Roger. _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
