On 22.07.2019 15:22, Juergen Gross wrote:
> @@ -756,6 +758,7 @@ void load_system_tables(void)
>               offsetof(struct tss_struct, __cacheline_filler) - 1,
>               SYS_DESC_tss_busy);
>   
> +        per_cpu(full_gdt_loaded, cpu) = false;
>       lgdt(&gdtr);
>       lidt(&idtr);
>       ltr(TSS_ENTRY << 3);

As per the surrounding code there should be a hard tab used for
indentation here.

> @@ -1739,8 +1743,7 @@ static void __context_switch(void)
>   
>       if ( need_full_gdt(nd) )
>           update_xen_slot_in_full_gdt(n, cpu);
> -
> -    if ( need_full_gdt(pd) &&
> +    if ( per_cpu(full_gdt_loaded, cpu) &&
>            ((p->vcpu_id != n->vcpu_id) || !need_full_gdt(nd)) )
>           load_default_gdt(cpu);

I think it wouldn't be bad if the blank line was kept.

If I end up committing this, I'll try to remember to do both
adjustments, unless you object for some reason.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to