On 01.08.2019 12:22, Chao Gao wrote:
> --- a/xen/arch/x86/microcode.c
> +++ b/xen/arch/x86/microcode.c
> @@ -383,10 +383,15 @@ static struct notifier_block microcode_percpu_nfb = {
>
> int __init early_microcode_update_cpu(bool start_update)
> {
> + unsigned int cpu = smp_processor_id();
> + struct ucode_cpu_info *uci = &per_cpu(ucode_cpu_info, cpu);
> int rc = 0;
> void *data = NULL;
> size_t len;
>
> + if ( !microcode_ops )
> + return -ENOSYS;
For posterity (realizing the patch has gone in already) - I'm not
convinced this should be an error condition, but the error
produced here is being ignored anyway afaics (i.e. the function
could as well return void). In no case is this an appropriate use
of ENOSYS: This isn't even on a hypercall path.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
