On 30.08.2019 14:12, Paul Durrant wrote: >> -----Original Message----- >> From: Igor Druzhinin <igor.druzhi...@citrix.com> >> Sent: 30 August 2019 12:57 >> To: xen-devel@lists.xenproject.org >> Cc: jbeul...@suse.com; Andrew Cooper <andrew.coop...@citrix.com>; Paul >> Durrant >> <paul.durr...@citrix.com>; w...@xen.org; Roger Pau Monne >> <roger....@citrix.com>; Igor Druzhinin >> <igor.druzhi...@citrix.com> >> Subject: [PATCH] x86/domain: don't destroy IOREQ servers on soft reset >> >> Performing soft reset should not opportunistically kill IOREQ servers >> for device emulators that might be currently running for a domain. >> Every emulator is supposed to clean up IOREQ servers for itself on exit. >> This allows a toolstack to elect whether or not a particular device >> model should be restarted. >> >> The original code was introduced in 3235cbfe ("arch-specific hooks for >> domain_soft_reset()") likely due to the fact 'default' IOREQ server >> existed in Xen at the time and used by QEMU didn't have an API call to >> destroy. Since the removal of 'default' IOREQ server from Xen this >> reason has gone away. >> >> Since commit ba7fdd64b ("xen: cleanup IOREQ server on exit") QEMU now >> destroys IOREQ server for itself as every other device emulator >> is supposed to do. It's now safe to remove this code from soft reset >> path - existing systems with old QEMU should be able to work as >> even if there are IOREQ servers left behind, a new QEMU instance will >> override its ranges anyway. >> >> Signed-off-by: Igor Druzhinin <igor.druzhi...@citrix.com> > > Reviewed-by: Paul Durrant <paul.durr...@citrix.com>
Acked-by: Jan Beulich <jbeul...@suse.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel