> -----Original Message-----
> From: Jan Beulich <jbeul...@suse.com>
> Sent: 30 August 2019 14:58
> To: Paul Durrant <paul.durr...@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Suravee Suthikulpanit
> <suravee.suthikulpa...@amd.com>; JulienGrall
> <julien.gr...@arm.com>; Andrew Cooper <andrew.coop...@citrix.com>; Roger Pau
> Monne
> <roger....@citrix.com>; Volodymyr Babchuk <volodymyr_babc...@epam.com>;
> George Dunlap
> <george.dun...@citrix.com>; Jun Nakajima <jun.nakaj...@intel.com>; Kevin Tian
> <kevin.t...@intel.com>;
> Stefano Stabellini <sstabell...@kernel.org>; Daniel De Graaf
> <dgde...@tycho.nsa.gov>; WeiLiu
> <w...@xen.org>
> Subject: Re: [PATCH v7 3/6] use is_iommu_enabled() where appropriate...
>
> On 30.08.2019 10:29, Paul Durrant wrote:
> > --- a/xen/include/asm-x86/iommu.h
> > +++ b/xen/include/asm-x86/iommu.h
> > @@ -61,8 +61,17 @@ extern struct iommu_ops iommu_ops;
> >
> > #ifdef NDEBUG
> > # include <asm/alternative.h>
> > -# define iommu_call(ops, fn, args...) alternative_call(iommu_ops.fn, ##
> > args)
> > -# define iommu_vcall(ops, fn, args...) alternative_vcall(iommu_ops.fn, ##
> > args)
> > +# define iommu_call(ops, fn, args...) \
> > +({ \
> > + (void)ops; \
> > + alternative_call(iommu_ops.fn, ## args); \
> > +})
> > +
> > +# define iommu_vcall(ops, fn, args...) \
> > +({ \
> > + (void)ops; \
> > + alternative_vcall(iommu_ops.fn, ## args); \
> > +})
> > #endif
>
> While unlikely to become an issue, "ops" should be parenthesized
> here. Also we commonly (but, granted, not consistently) put ({ on
> the #define line. Can both be done while committing.
>
Ok, thanks.
Paul
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
