On 05.11.2019 20:43, Andrew Cooper wrote: > --- a/xen/common/livepatch.c > +++ b/xen/common/livepatch.c > @@ -1076,25 +1076,33 @@ static int apply_payload(struct payload *data) > * temporarily disable the spin locks IRQ state checks. > */ > spin_debug_disable(); > - for ( i = 0; i < data->n_load_funcs; i++ ) > - data->load_funcs[i](); > + for ( i = 0; !rc && i < data->n_load_funcs; i++ ) > + rc = data->load_funcs[i](); > spin_debug_enable(); > > + if ( rc ) > + printk(XENLOG_ERR LIVEPATCH "%s: load_funcs[%u] failed: %d\n", > + data->name, i, rc);
Is there a possible problem here if some of the load_funcs() succeeded before one fails? Or are those required to not do any state change to the system (which would need rolling back)? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel