On 10/7/19 4:12 PM, Nick Rosbrook wrote: > From: Nick Rosbrook <rosbro...@ainfosec.com> > > Define StringList as []string an implement fromC and toC functions. > > Signed-off-by: Nick Rosbrook <rosbro...@ainfosec.com> > --- > Cc: George Dunlap <george.dun...@citrix.com> > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > Cc: Wei Liu <w...@xen.org> > > tools/golang/xenlight/xenlight.go | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/tools/golang/xenlight/xenlight.go > b/tools/golang/xenlight/xenlight.go > index 09fcdca5d1..a3a1836d31 100644 > --- a/tools/golang/xenlight/xenlight.go > +++ b/tools/golang/xenlight/xenlight.go > @@ -234,6 +234,35 @@ func (kvl KeyValueList) toC() (C.libxl_key_value_list, > error) { > return ckvl, nil > } > > +// StringList represents a libxl_string_list. > +type StringList []string > + > +func (sl StringList) fromC(csl *C.libxl_string_list) error { > + size := int(C.libxl_string_list_length(csl)) > + list := (*[1 << 30]*C.char)(unsafe.Pointer(csl))[:size:size] > + > + sl = make([]string, size)
Doesn't this method want a pointer receiver? Everything else looks good. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel