On 10/7/19 4:13 PM, Nick Rosbrook wrote:
> From: Nick Rosbrook <rosbro...@ainfosec.com>
>
> Re-define Hwcap as [8]uint32, and implement toC function. Also, re-name and
> modify signature of toGo function to fromC.
>
> Signed-off-by: Nick Rosbrook <rosbro...@ainfosec.com>
Looks good. Just one comment...
> ---
> Cc: George Dunlap <george.dun...@citrix.com>
> Cc: Ian Jackson <ian.jack...@eu.citrix.com>
> Cc: Wei Liu <w...@xen.org>
>
> tools/golang/xenlight/xenlight.go | 29 +++++++++++++++++++----------
> 1 file changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/tools/golang/xenlight/xenlight.go
> b/tools/golang/xenlight/xenlight.go
> index 3e3753f92e..8d520bbd98 100644
> --- a/tools/golang/xenlight/xenlight.go
> +++ b/tools/golang/xenlight/xenlight.go
> @@ -307,20 +307,29 @@ type Context struct {
> logger *C.xentoollog_logger_stdiostream
> }
>
> -type Hwcap []C.uint32_t
> -
> -func (chwcap C.libxl_hwcap) toGo() (ghwcap Hwcap) {
> - // Alloc a Go slice for the bytes
> - size := 8
> - ghwcap = make([]C.uint32_t, size)
> +// Hwcap represents a libxl_hwcap.
> +type Hwcap [8]uint32
>
> +func (hwcap *Hwcap) fromC(chwcap *C.libxl_hwcap) error {
> // Make a slice pointing to the C array
> - mapslice := (*[1 <<
> 30]C.uint32_t)(unsafe.Pointer(&chwcap[0]))[:size:size]
> + mapslice := (*[8]C.uint32_t)(unsafe.Pointer(chwcap))
To be pedantic, this isn't a slice anymore. :-) Do you want to change
this to 'b' (or maybe 'u' or something like that) and fix the comment?
With that changed:
Reviewed-by: George Dunlap <george.dun...@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
