> -----Original Message----- > From: Xen-devel <xen-devel-boun...@lists.xenproject.org> On Behalf Of Wei > Liu > Sent: 21 November 2019 19:51 > To: Xen Development List <xen-devel@lists.xenproject.org> > Cc: Wei Liu <li...@microsoft.com>; Wei Liu <w...@xen.org>; Andrew Cooper > <andrew.coop...@citrix.com>; Michael Kelley <mikel...@microsoft.com>; Jan > Beulich <jbeul...@suse.com>; Roger Pau Monné <roger....@citrix.com> > Subject: [Xen-devel] [PATCH v4 6/8] x86: switch xen guest implementation > to use hypervisor framework > > Signed-off-by: Wei Liu <li...@microsoft.com> [snip] > diff --git a/xen/include/asm-x86/guest/xen.h b/xen/include/asm- > x86/guest/xen.h > index 01dc3ee6f6..db90b550a7 100644 > --- a/xen/include/asm-x86/guest/xen.h > +++ b/xen/include/asm-x86/guest/xen.h > @@ -23,6 +23,7 @@ > > #include <asm/e820.h> > #include <asm/fixmap.h> > +#include <asm/guest/hypervisor.h> > > #define XEN_shared_info ((struct shared_info > *)fix_to_virt(FIX_XEN_SHARED_INFO)) > > @@ -32,7 +33,7 @@ extern bool xen_guest; > extern bool pv_console; > extern uint32_t xen_cpuid_base; > > -void probe_hypervisor(void); > +const struct hypervisor_ops *xen_probe(void); > int xg_alloc_unused_page(mfn_t *mfn); > int xg_free_unused_page(mfn_t mfn); > > @@ -44,7 +45,7 @@ DECLARE_PER_CPU(struct vcpu_info *, vcpu_info); > #define xen_guest 0 > #define pv_console 0
Nit: These should be #defined to false rather than 0. The rest LGTM so with those fixed, Reviewed-by: Paul Durrant <pdurr...@amazon.com> > > -static inline void probe_hypervisor(void) {} > +static inline const struct hypervisor_ops *xen_probe(void) { return NULL; > } > > #endif /* CONFIG_XEN_GUEST */ > #endif /* __X86_GUEST_XEN_H__ */ > -- > 2.20.1 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel