On Wed, Nov 27, 2019 at 10:10:07AM -0500, Pavel Tatashin wrote: > Hi Mark, > > Thank you for reviewing this work. > > The 'arch_' prefix should probably be 'asm_' (or have an '_asm' suffix), > > since this is entirely local to the arch code, and even then should only > > be called from the C wrappers. > > Sure, I can change it to asm_*, I was using arch_* to be consistent > with __arch_copy_from_user() and friends.
FWIW, that naming was from before the common uaccess code took on the raw_* anming for the arch functions, and I was expecting that the arch_* functions would end up being called from core code. For now it's probably too churny to change that existing case. Thanks, Mark. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel