On 27.11.2019 10:19, Roger Pau Monné wrote: > On Tue, Nov 26, 2019 at 03:01:11PM +0000, Andrew Cooper wrote: >> Unhandled IOMMU errors (i.e. not IO_PAGE_FAULT) should still be printed, and >> not hidden behind iommu=debug. >> >> While adjusting this, factor out the symbolic name handling to just one >> location exposing its off-by-one nature. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.comi> > > LGTM: > > Reviewed-by: Roger Pau Monné <roger....@citrix.com>
Acked-by: Jan Beulich <jbeul...@suse.com> > I wonder however whether XENLOG_G_ERR should be used instead of > XENLOG_ERR in order to rate limit IOMMU faults triggered by guests. IO_PAGE_FAULT uses XENLOG_ERR as well, so I'd stick to it. If there are really massive amounts of faults, log spam won't be our only problem, I think. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel