Hi, On 29/11/2019 10:13, Jan Beulich wrote:
The switch of guest_console_write()'s second parameter from plain to unsigned int has caused the function's main loop header to no longer guard the min_t() use within the function against effectively negative values, due to the casts hidden inside the macro. Replace by a plain min(), converting one of the arguments suitably without involving any cast.Fixes: ea601ec9995b ("xen/console: Rework HYPERCALL_console_io interface") Reported-by: Ilja Van Sprundel <ivansprun...@ioactive.com> Signed-off-by: Jan Beulich <jbeul...@suse.com>
Sorry for the breakage. Acked-by: Julien Grall <jul...@xen.org> Cheers,
--- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -538,7 +538,7 @@ static long guest_console_write(XEN_GUES __HYPERVISOR_console_io, "iih", CONSOLEIO_write, count, buffer);- kcount = min_t(int, count, sizeof(kbuf)-1);+ kcount = min(count + sizeof(char[0]), sizeof(kbuf) - 1); if ( copy_from_guest(kbuf, buffer, kcount) ) return -EFAULT;
-- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
