On Thu, Dec 12, 2019 at 02:11:32PM +0000, Ian Jackson wrote: > Thanks for tidying this up. > > Juergen Gross writes ("[PATCH-for-4.13] build: fix tools/configure in case > only python3 exists"): > > -AS_IF([test -z "$PYTHON"], [PYTHON="python"]) > > -AS_IF([echo "$PYTHON" | grep -q "^/"], [], [PYTHON=`type -p "$PYTHON"`]) > > +AS_IF([test -z "$PYTHON"], [AC_CHECK_PROGS([PYTHON], [python python3 > > python2], err)]) > > +AS_IF([test "$PYTHON" = "err"], [AC_MSG_ERROR([No python interpreter > > found])]) > > I think this use of `err' is a bit odd. According to the FM you could > say simply: > > +AS_IF([test -z "$PYTHON"], [AC_CHECK_PROGS([PYTHON], [python python3 > python2])]) > +AS_IF([test -z "$PYTHON"], [AC_MSG_ERROR([No python interpreter found])]) > > But this is a style nit I think since no-one will call their python > interpreter `err' :-). And you will have tested your version and at > this stage of 4.13 it would be better to have fewer iterations of this > patch, so I think it should go in as it is. > > > +AS_IF([echo "$PYTHON" | grep -q "^/"], [], [AC_PATH_PROG([PYTHON], > > [$PYTHON])]) > > Thanks. > > Reviewed-by: Ian Jackson <ian.jack...@eu.citrix.com>
Thanks. I will push this to staging and staging-4.13 shortly. Wei. > > Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel